Conversation
- bumped LangVersion to 11.0 - added basic AGENTS.md +semver: breaking
+semver: breaking
There was a problem hiding this comment.
Pull request overview
This PR updates FixedMathSharp’s supported runtimes and serialization strategy, moving away from legacy .NET Framework/MessagePack toward .NET Standard + MemoryPack, and updates the test/CI setup accordingly.
Changes:
- Switch serialization attributes and tests from MessagePack/BinaryFormatter to MemoryPack (plus System.Text.Json tests).
- Update target frameworks (library to
netstandard2.1+ .NET 8; tests to .NET 8) and bump xUnit to v3. - Simplify CI to run
dotnet teston Linux + Windows and modernize GitVersion usage.
Reviewed changes
Copilot reviewed 30 out of 34 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FixedMathSharp.Tests/Vector3d.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Vector2d.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Support/FixedMathTestHelper.cs | Formatting-only adjustments in helper assertions. |
| tests/FixedMathSharp.Tests/FixedRange.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/FixedQuanternion.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/FixedMathSharp.Tests.csproj | Move tests to .NET 8 + xUnit v3 packages; adjust test project settings. |
| tests/FixedMathSharp.Tests/FixedCurveTests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Fixed64.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Fixed4x4.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Fixed3x3.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/DeterministicRandom.Tests.cs | Minor using cleanup/reordering. |
| tests/FixedMathSharp.Tests/Bounds/BoundingSphere.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Bounds/BoundingBox.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| tests/FixedMathSharp.Tests/Bounds/BoundingArea.Tests.cs | Update serialization tests to MemoryPack; remove net48-specific code paths. |
| src/FixedMathSharp/Utility/DeterministicRandom.cs | Whitespace-only changes around argument checks. |
| src/FixedMathSharp/Numerics/Vector3d.cs | Replace MessagePack attributes with MemoryPack equivalents. |
| src/FixedMathSharp/Numerics/Vector2d.cs | Replace MessagePack attributes with MemoryPack equivalents. |
| src/FixedMathSharp/Numerics/FixedRange.cs | Replace MessagePack attributes with MemoryPack equivalents; make type partial for generator. |
| src/FixedMathSharp/Numerics/FixedQuaternion.cs | Replace MessagePack attributes with MemoryPack equivalents; adjust exception text and nullable signature. |
| src/FixedMathSharp/Numerics/FixedCurveKey.cs | Replace MessagePack attributes with MemoryPack equivalents; simplify hashing. |
| src/FixedMathSharp/Numerics/FixedCurve.cs | Replace MessagePack attributes with MemoryPack equivalents; update constructor attribute and indexing. |
| src/FixedMathSharp/Numerics/Fixed64.cs | Replace MessagePack attributes with MemoryPack equivalents. |
| src/FixedMathSharp/Numerics/Fixed4x4.cs | Replace MessagePack attributes with MemoryPack equivalents; make type partial for generator. |
| src/FixedMathSharp/Numerics/Fixed3x3.cs | Replace MessagePack attributes with MemoryPack equivalents; remove unused using. |
| src/FixedMathSharp/Numerics/Extensions/Fixed64.Extensions.cs | Remove unused usings / whitespace cleanup. |
| src/FixedMathSharp/FixedMathSharp.csproj | Update TFMs and replace MessagePack dependency with MemoryPack. |
| src/FixedMathSharp/Core/FixedTrigonometry.cs | Minor whitespace cleanup. |
| src/FixedMathSharp/Core/FixedMath.cs | Minor whitespace cleanup. |
| src/FixedMathSharp/Bounds/BoundingSphere.cs | Replace MessagePack attributes with MemoryPack equivalents; formatting tweaks in Intersects. |
| src/FixedMathSharp/Bounds/BoundingBox.cs | Replace MessagePack attributes with MemoryPack equivalents; refactor Min/Max storage and add serialized version member. |
| src/FixedMathSharp/Bounds/BoundingArea.cs | Replace MessagePack attributes with MemoryPack equivalents; formatting tweaks in Intersects. |
| README.md | Update stated serialization and compatibility docs for MemoryPack + new TFMs. |
| AGENTS.md | Add agent guidance document (currently inconsistent with this PR’s changes). |
| .github/workflows/dotnet.yml | Switch to OS matrix and run dotnet test; modernize GitVersion integration; remove net48/Mono steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
…om review feedback (#45) * fix: apply PR review feedback - TFMs, exception args, stray semicolons, XML doc, AGENTS.md Co-authored-by: mrdav30 <11547347+mrdav30@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mrdav30 <11547347+mrdav30@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 35 changed files in this pull request and generated 17 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
…, CI internal PRs, nullable deserialization, per-arg quaternion exceptions (#46) * Initial plan * Apply review feedback: rename MsgPack tests, fix Union Version, CI workflow, null check, separate exceptions Co-authored-by: mrdav30 <11547347+mrdav30@users.noreply.github.com> * Update src/FixedMathSharp/Bounds/BoundingBox.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mrdav30 <11547347+mrdav30@users.noreply.github.com> Co-authored-by: mrdav30 <david.oravsky@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.